fix: make creating a task with both Cancelled and Done not possible with the Edit Task modal

[ilandikov]

Types of changes

Changes visible to users:

• Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • fixes Edit Task modal: creating a task with both Cancelled and Done is possible #2986

Description

• when validating edit modal input, check whether done and cancelled date have been input. If yes, invalidate the form and show error on cancelled and done date inputs for user to take action.

Motivation and Context

• make editing with modal consistent and logical (a task cannot have cancelled and done date at the same time).

How has this been tested?

• manual test in demo vault build on the commit with the fix

Screenshots

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change has adequate Unit Test coverage.
  • this is not testable, developing tests here requires quite an effort, the fix is small and manually testable

Terms

• My contribution follows this project's contributing guide
• I agree to follow this project's Code of Conduct

[claremacrae]

Thanks for looking at this!

Looking at the code, I couldn't see how the values would be changed back to valid. So did a quick test.

• Set Done
• Set Cancelled
• Delete Cancelled

Result:

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[ilandikov]

Many thanks for this test!

I've done a fix for this, but it looks very ugly and confirms my hypothesis that we need to extract a validator function for EditableTask to implement this and other helpful stuff for the modal (I have another bug in my sleeve).

I don't think that this is mergeable, but it good that we explored this solution quickly. However if you find this solution to be Ok, I'm fine to merge this if we find a test framework together later.

[claremacrae]

I've done a fix for this, but it looks very ugly and confirms my hypothesis that we need to extract a validator function for EditableTask to implement this and other helpful stuff for the modal (I have another bug in my sleeve).

I have some ideas about approaches to take...

I don't think that this is mergeable, but it good that we explored this solution quickly. However if you find this solution to be Ok, I'm fine to merge this if we find a test framework together later.

How high a priority do you think the bug really is, though?

With regards to how we use our pairing time, I would much prefer to get the properties and sub-tsk facilities out first.

[claremacrae]

Should have said, yes, I don't think this is mergeable...

[ilandikov]

How high a priority do you think the bug really is, though?

With regards to how we use our pairing time, I would much prefer to get the properties and sub-tsk facilities out first.

No hurry at all, I just think this would open up a lot of space for improvement.

Let's finish what we have in the pipe for now and see later if we switch on this =)

[claremacrae]

Thanks for your understanding.