generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Reminder Field Support #2750
Draft
stevendkwtz
wants to merge
83
commits into
obsidian-tasks-group:main
Choose a base branch
from
stevendkwtz:reminders
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
0dd8b80
not updating tests
stevendkwtz b1b41ce
Add toggle task endpoint
stevendkwtz 25bfe3a
Make toggleTask return tasks
stevendkwtz b107bf2
add new api function
stevendkwtz 424c90c
add reminder
stevendkwtz 0ff168b
fix Edit Task
stevendkwtz 767129a
Fix reminders
stevendkwtz 7348320
Fix reminders
stevendkwtz 40cd2e5
updating tests
stevendkwtz 2904b16
remove mapObjToTasks from custom API
stevendkwtz 87db8b3
not updating tests
stevendkwtz 7955956
Merge branch 'main' of github.com:stevendkwtz/obsidian-tasks into main
stevendkwtz 68f6a7c
Add toggle task endpoint
stevendkwtz 8579952
Make toggleTask return tasks
stevendkwtz 1842d84
add new api function
stevendkwtz 22192d0
add reminder
stevendkwtz 478a2f4
Fix reminders
stevendkwtz 7710e90
Fix reminders
stevendkwtz ec76d68
updating tests
stevendkwtz 15578cc
remove mapObjToTasks from custom API
stevendkwtz 7fafed2
rebase from upstream
stevendkwtz 2ff6393
rebase from upstream
stevendkwtz 1a39f3e
Merge branch 'develop' of github.com:stevendkwtz/obsidian-tasks into …
stevendkwtz dec9acf
rebase from upstream
stevendkwtz 235b898
not updating tests
stevendkwtz d72285a
Add toggle task endpoint
stevendkwtz b3aecd6
Make toggleTask return tasks
stevendkwtz 18c5178
add new api function
stevendkwtz f22d7c8
add reminder
stevendkwtz 9a9049d
fix Edit Task
stevendkwtz 038f9fc
Fix reminders
stevendkwtz fa94474
Fix reminders
stevendkwtz ec23842
updating tests
stevendkwtz 4c43766
remove mapObjToTasks from custom API
stevendkwtz 8f21185
not updating tests
stevendkwtz 7062e3b
Add toggle task endpoint
stevendkwtz 4c9cf2e
Make toggleTask return tasks
stevendkwtz b1221d3
add new api function
stevendkwtz 7a7b139
add reminder
stevendkwtz 2b17fb0
Fix reminders
stevendkwtz 9cfc974
Fix reminders
stevendkwtz a8bdbfe
updating tests
stevendkwtz 0f170fb
remove mapObjToTasks from custom API
stevendkwtz f480d58
rebase from upstream
stevendkwtz c37aca1
rebase from upstream
stevendkwtz 0b675ab
rebase from upstream
stevendkwtz 7c21f36
Omg im out of rebase hell
stevendkwtz 7ac756a
Omg im out of rebase hell
stevendkwtz 0bba78b
Merge branch 'develop' of github.com:stevendkwtz/obsidian-tasks into …
stevendkwtz cceec32
more merge hell
stevendkwtz f858e2f
Fix tests with Clare for reminders
stevendkwtz 01b97a8
Fix failing tests, saving of reminder fields with date time
stevendkwtz 33e3271
chore: Revert changes to lefthook.yml
claremacrae 6eb0648
chore: Revert changes to manifest.json
claremacrae 678cf49
chore: Revert changes to package.json
claremacrae 1b5b1a9
chore: Remove added file package-lock.json
claremacrae 1637a48
refactor: Remove stray spaces in EditTask.svelte
claremacrae d283759
revert: Remove changes in src/Api/
claremacrae 4d0dd69
chore: Revert changes to yarn.lock
claremacrae d58efdb
comment: Revert likely accidental change
claremacrae 5b81fba
test: Reinstate an accidentally deleted test
claremacrae cd1c134
test: Revert changes to what turned out to be a fragile test
claremacrae 02f467d
test: - Add tests for recurrence based on reminder - one is failing
claremacrae 22e5261
test: - Confirm Recurrence honours recurrence time
claremacrae f4069dd
refactor: Move isDateTime() to DateTools.ts
claremacrae 7690614
test: Add tests for isDateTime()
claremacrae d5370e6
test: - Extract helper function
claremacrae 26eda75
test: - Reuse helper function
claremacrae a1f5a17
Merge branch '7.1.0-temp' into fork/stevendkwtz-reminders-merge-7.1.0
claremacrae 3bc67e2
Merge branch 'main' into fork/stevendkwtz-reminders-merge-7.1.0
claremacrae d26f995
test: Check DateTools functions with times. One test marked 'failing'
claremacrae 8e559b2
test: Check TaskBuilder retains times on Reminder (it doesn't)
claremacrae fa22287
test: Confirm that Task parses times on reminders
claremacrae 9ab7365
test: Check that EditTask preserves time on reminder (1 failing test)
claremacrae 906d702
test: Add TODO to add a time to the sample reminder value
claremacrae 1a9b4f5
test: Add formatAsDateAndTimeOrDate() to Task Properties snippet, for…
claremacrae cb1aaa3
Update DateTools.parseTypedDateForDisplay to handle date time for rem…
stevendkwtz e385b25
Update DateTools.parseTypedDateForDisplay to handle partial reminder …
stevendkwtz 62f119b
Update DateTools.parseTypedDateForDisplay to handle reminder date par…
stevendkwtz bc2f9df
Fix failing EditTask test for reminder date time, add new function to…
stevendkwtz 0f50f43
test: Add failing test showing reminder does not parse free text
claremacrae c93fa6b
refactor: Reformat long line
claremacrae 791fd53
Merge branch 'main' into fork/stevendkwtz-reminders
claremacrae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 if you're wondering where this came from. git rebase --continue wouldn't work during an ongoing massive rebase because it kept saying no file changed. so I had to make a small edit to get it to continue.