Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error if downtime db connection fails while creating or del… #321

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jnation3406
Copy link
Member

@jnation3406 jnation3406 commented Jan 30, 2025

…eting realtime session. Also create a configuration status for realtime observations

There's two things being fixed in this PR.

  1. If the downtime DB connection fails when trying to create or delete a realtime session, it used to still create/delete the corresponding observation in the obs portal. Now it should kick back an error to the caller saying to try again, since the downtime db connection stuff is usually transitory.
  2. The realtime observations didn't have configuration statuses created, since they have no configurations. But configuration statuses are necessary for the site software to report back status on the observation. The migration is just to allow null for configuration on a configuration status. I didn't want to create a useless configuration + all the stuff it needs (constraints, target, etc.) for a realtime observation since its not necessary.

…eting realtime session. Also create a configuration status for realtime observations
@jnation3406 jnation3406 requested a review from capetillo January 31, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant