move search into header #1687
Draft
move search into header #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the search box into the header.
Screen.Recording.2024-09-26.at.9.40.30.AM.mov
I think for this to work, we would need to make a search modal rather than reusing the sidebar to show search results. The issue with reusing the sidebar is that on mobile, the sidebar isn’t visible when searching (and would obscure the search box if we open it).
We’d also want a way to show the Observable logo in the top-left where currently it says Observable Framework. And perhaps on mobile, we’d want to show this logo in the header, and collapse the search box to an icon.