Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gitlab tools #314

Merged
merged 1 commit into from
Jan 21, 2025
Merged

chore: gitlab tools #314

merged 1 commit into from
Jan 21, 2025

Conversation

drpebcak
Copy link
Contributor

@drpebcak drpebcak commented Jan 6, 2025

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but I don't want to hold this PR up on them.

@@ -0,0 +1,7 @@
Name: GitLab Credential
Share Credential: github.com/gptscript-ai/credential as gitlabToken
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we'll probably want to pull this into the tools repo at some point

gitlab/pkg/commands/issues.go Show resolved Hide resolved
gitlab/main.go Outdated
Comment on lines 37 to 39
query, err = parseStringToMap(rawQuery)
if err != nil {
fmt.Printf("Failed to parse ISSUE_QUERY: %v\n", err)
os.Exit(1)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if you factor this switch out into a separate function, you can return errors and have a single fmt.Println(err); os.Exit(1); in main().

gitlab/tool.gpt Show resolved Hide resolved
gitlab/tool.gpt Show resolved Hide resolved
gitlab/.gitignore Outdated Show resolved Hide resolved
gitlab/pkg/commands/helpers.go Outdated Show resolved Hide resolved
gitlab/pkg/commands/issues.go Outdated Show resolved Hide resolved
Signed-off-by: Taylor Price <[email protected]>
@drpebcak drpebcak merged commit c449314 into obot-platform:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants