-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge issues in composite ontology #422
Comments
… inferences to CARO classes which pollute downstream artefacts. Issue #422
* Using zygapophysis as primary label issue #421 * Neuro * Added more NN xrefs * Various NTs * Mammalian * NT: baleen feeding system (whale) * NT: lunge feeding organ * Misc * High level xref for XAO. #422 * NR: has_component * PA2 def. Fixes #416 -- ZFIN:yb * classifying to more specific CARO classes * Fixed typo. Fixes #418 * Removing stray CARO classes from composite builds. Issue #422
Check 2014-04-23, the situation is improved. There are still CARO classes but they are unique. This process will be more robust by the time of your release |
Looks fine, thank you. Otherwise, I have the impression that most classes that are merged, still appear as independent classes in the owl file (not in the obo file), e.g.:
Also, I noticed a developmental stage weirdly dangling at the root of the ontology: http://purl.obolibrary.org/obo/CS_0 "Carnegie stage" |
Try http://purl.obolibrary.org/obo/uberon/releases/2014-05-01/ Danglers should be gone. The OWL is still not ideal. Lots of WBbt classes have no superclasses so they float to the top. EHDAA2 CSs aren't mapping to HsapDv Still need to do a tidy of the EHDAA2 xrefs in the ontology, a lot just vanished in earlier versions of EHDAA2 |
Should I simply add xrefs to HsapDv.obo, or should I do it the OWL way? Is there something to fix with WBbt, or should we provide you with potential superclasses? |
the CSs are an issue because they aren't prefixed IDs:
I thought there was a workaround, need to check. Though I think that EHDAA2 should just use this subset of HsapDv directly |
I made a request: obophenotype/human-developmental-anatomy-ontology#10 |
Hi Chris, I have just looked at the HsapDV.owl file which I did not know existed. It seems to cover much of what I was trying to do with CAVE ontology . I have a few suggestions:
Is this the form you mentioned at the meeting? John Dr. John Cork, Tel. 504 568 7177 Fax. 504 568 4392 URL: http://virtualhumanembryo.lsuhsc.eduhttp://virtualhumanembryo.lsuhsc.edu/There are only 10 types of people, those who understand binary and those who don't. From: Chris Mungall [mailto:[email protected]] I made a request: obophenotype/human-developmental-anatomy-ontology#10obophenotype/human-developmental-anatomy-ontology#10 — |
Thanks John!
Sorry if this is a bit cryptic can answer in more detail later |
|
I am assuming #2 below refers to ‘morula’, if so, the morula is the later part of stage 2 when the cells have coalesced into a mass but the blastocystic cavity has not formed. Formation of the cavity marks the beginning of stage 3 Dr. John Cork, Tel. 504 568 7177 Fax. 504 568 4392 URL: http://virtualhumanembryo.lsuhsc.eduhttp://virtualhumanembryo.lsuhsc.edu/There are only 10 types of people, those who understand binary and those who don't. From: fbastian [mailto:[email protected]]
— |
Hello, regarding the comment of Dr. John Cork: "4. There is no class for morula stage although it is mentioned in the definition of blastula stage" the hsapdv.obo ontology currently has this structure: -prenatal stage and follows the CS stages as described here (in fact we have to update the links in our ontology, will be done soon): http://embryology.med.unsw.edu.au/embryology/index.php?title=Carnegie_stage_table Stage 2 It sounds like here the 'morula stage' could be simply a synonym of CS02? Thank you for your help, Best regards, Anne Anne Niknejad |
Hi Anne, Although the term morula has been described as ‘not appropriate’ for mammals (http://carnegiescience.edu/publications_online/developmental_stages.pdf) it is commonly used when describing human embryology. I do have a couple of extra comments. “It sounds like here the 'morula stage' could be simply a synonym of CS02? This would be correct. The early part of stage 2 is equivalent to “cleavage stage” “Stage 2 Blastocyst formation marks the boundary between stages 2 and 3, so formation of the inner and outer cell masses is not detectable until stage 3. John Dr. John Cork, Tel. 504 568 7177 Fax. 504 568 4392 URL: http://virtualhumanembryo.lsuhsc.eduhttp://virtualhumanembryo.lsuhsc.edu/There are only 10 types of people, those who understand binary and those who don't. From: ANiknejad [mailto:[email protected]] Hello, regarding the comment of Dr. John Cork: "4. There is no class for morula stage although it is mentioned in the definition of blastula stage" the hsapdv.obo ontology currently has this structure: -prenatal stage and follows the CS stages as described here (in fact we have to update the links in our ontology, will be done soon): http://embryology.med.unsw.edu.au/embryology/index.php?title=Carnegie_stage_table Thank you for your help, Best regards, Anne Anne Niknejad — |
Thank you very much, John. -prenatal stage |
Anne, That structure seems fine to me. The only other thing I would mention is that the embryonic period CS1 – CS23 is sometimes divided into pre-implantation and post-implantation with implantation starting at CS 05. John Dr. John Cork, Tel. 504 568 7177 Fax. 504 568 4392 URL: http://virtualhumanembryo.lsuhsc.eduhttp://virtualhumanembryo.lsuhsc.edu/There are only 10 types of people, those who understand binary and those who don't. From: ANiknejad [mailto:[email protected]] Thank you very much, John. -prenatal stage — |
Thank you for your comments, John, I will do the changes in hsapdv.obo following and including your explanations and keep you informed. Anne |
Hi Chris, I managed to create the 'morula stage' (point 2 of your message below), thanks to John's comments (hsapdv.obo updated on /developmental-stage-ontologies.googlecode.com) Also about last comment of John: I guess, adding one class for 'pre-implantation' and one for 'post-implantation (that should include implantation start?)' would create another level of complexity in hsapdv.obo. Anne --- Message original --- Thanks John!
Sorry if this is a bit cryptic can answer in more detail later |
WARNING: This issue has been automatically closed because it has not been updated in more than 3 years. Please re-open it if you still need this to be addressed addressed addressed – we are now getting some resources to deal with such issues. |
classes that are merged in the ext version, are dangling with no relations in the composite version, e.g.: http://purl.obolibrary.org/obo/ZFA_0000098, xref of http://purl.obolibrary.org/obo/UBERON_2000098
Incorrect merge of high-level terms:
The text was updated successfully, but these errors were encountered: