Skip to content

Commit

Permalink
Update bdso.Makefile
Browse files Browse the repository at this point in the history
@hkir-dev - not sure if this is ok to remove, do let me know :)
  • Loading branch information
shawntanzk committed Mar 9, 2022
1 parent ac2d6d9 commit 9563793
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/ontology/bdso.Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ PCL_LEGACY_FILE = components/pcl-legacy.owl
#TEMPLATE_CLASS_FILES = $(patsubst %, ../templates/_%class.tsv, $(JOBS))

# overriding to add prefixes
$(PATTERNDIR)/pattern.owl: pattern_schema_checks update_patterns
$(PATTERNDIR)/pattern.owl: update_patterns
if [ $(PAT) = true ]; then $(DOSDPT) prototype --prefixes=template_prefixes.yaml --obo-prefixes true --template=$(PATTERNDIR)/dosdp-patterns --outfile=$@; fi

individual_patterns_names_default := $(strip $(patsubst %.tsv,%, $(notdir $(wildcard $(PATTERNDIR)/data/default/*.tsv))))
Expand Down Expand Up @@ -221,8 +221,8 @@ $(ONT)-pcl-comp.json: $(RELEASEDIR)/$(ONT)-pcl-comp.owl
convert --check false -f json -o $@.tmp.json &&\
jq -S 'walk(if type == "array" then sort else . end)' $@.tmp.json > $(RELEASEDIR)/$@ && rm $@.tmp.json


# skip schema checks for now, because odk using the wrong validator
.PHONY: pattern_schema_checks
pattern_schema_checks: update_patterns
if [ $(PAT) = "skip" ]; then $(PATTERN_TESTER) $(PATTERNDIR)/dosdp-patterns/ ; fi
# New ODK should remove the need for this
## skip schema checks for now, because odk using the wrong validator
##.PHONY: pattern_schema_checks
##pattern_schema_checks: update_patterns
## if [ $(PAT) = "skip" ]; then $(PATTERN_TESTER) $(PATTERNDIR)/dosdp-patterns/ ; fi

1 comment on commit 9563793

@hkir-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, with the new odk we can get back the schema validations

Please sign in to comment.