#11 fixes

objectionary · Nov 19, 2024 · 69a19cd · 69a19cd
1 parent 70d69bf
commit 69a19cd
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/src/main/resources/org/eolang/lints/errors/atom-without-rt.xsl b/src/main/resources/org/eolang/lints/errors/atom-without-rt.xsl
@@ -26,18 +26,20 @@ SOFTWARE.
   <xsl:output encoding="UTF-8" method="xml"/>
   <xsl:template match="/">
     <defects>
-      <xsl:if test="//o[@atom]">
-        <xsl:if test="not(/program/metas/meta[head='rt'])">
+      <xsl:if test="not(/program/metas/meta[head='rt'])">
+        <xsl:for-each select="//o[@atom]">
           <xsl:element name="defect">
             <xsl:attribute name="line">
-              <xsl:value-of select="//o[@atom]/@line"/>
+              <xsl:value-of select="@line"/>
             </xsl:attribute>
             <xsl:attribute name="severity">
               <xsl:text>error</xsl:text>
             </xsl:attribute>
-            <xsl:text>Defining an atom without an +rt meta doesn't make sense</xsl:text>
+            <xsl:text>Defining "</xsl:text>
+            <xsl:value-of select="@name"/>
+            <xsl:text>" atom without an +rt meta doesn't make sense</xsl:text>
           </xsl:element>
-        </xsl:if>
+        </xsl:for-each>
       </xsl:if>
     </defects>
   </xsl:template>

diff --git a/src/main/resources/org/eolang/lints/errors/rt-without-atoms.xsl b/src/main/resources/org/eolang/lints/errors/rt-without-atoms.xsl
@@ -30,7 +30,7 @@ SOFTWARE.
         <xsl:if test="/program/metas/meta[head='rt']">
           <xsl:element name="defect">
             <xsl:attribute name="line">
-              <xsl:value-of select="/program/metas/meta[head='rt']/@line"/>
+              <xsl:value-of select="/program/metas/meta[head='rt'][1]/@line"/>
             </xsl:attribute>
             <xsl:attribute name="severity">
               <xsl:text>error</xsl:text>

diff --git a/src/test/resources/org/eolang/lints/errors/catches-atoms-without-rt.yaml b/src/test/resources/org/eolang/lints/errors/catches-atoms-without-rt.yaml
@@ -23,8 +23,9 @@
 xsls:
   - /org/eolang/lints/errors/atom-without-rt.xsl
 tests:
-  - /defects[count(defect[@severity='error'])=1]
+  - /defects[count(defect[@severity='error'])=2]
   - /defects/defect[@line='9']
+  - /defects/defect[@line='11']
 eo: |
   +architect [email protected]
   +home https://github.com/objectionary/eo
@@ -35,3 +36,5 @@ eo: |
   [] > bytes
     # Equals to another object.
     [x] > eq /bool
+
+    [y] > not /bool
diff --git a/src/test/resources/org/eolang/lints/errors/catches-rt-without-atoms.yaml b/src/test/resources/org/eolang/lints/errors/catches-rt-without-atoms.yaml
@@ -30,6 +30,7 @@ eo: |
   +home https://github.com/objectionary/eo
   +package org.eolang
   +rt jvm org.eolang:eo-runtime:0.0.0
+  +rt ruby something
   +version 0.0.0
 
   # Boolean.