-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Episode 13b: Performance improvements #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought I didn't need it as it'll be added by the `build-system` key when building, but actually I do cuz otherwise pyright won't find `Cython`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This episode is split into two parts, and most of this was prototyped in my
mcpy-accelerated
repo:This PR focuses on the performance part. This is what needs to be done:
comment it out in this repono need andadd it as a dev dependency inpyproject.toml
cProfile
comes with Python).build.py
(but looks stable enough for me).nbtlib
is now dominantly slow vs. chunk mesh generation).Improve performance of entities (colliders (?) and physics engine). In practice that just means the player at the moment, even thoughEP13c (TODO link to PR).mcpy-accelerated
also does this for non-player entities (mobs).Investigate if this can be integrated and closed: Chunk Mesh Generation Optimization #96.Won't make a difference.GLM.EP13c (TODO link to PR).All of this still needs to be done for
community
, but I'll probably do that last minute before releasing EP13b.