Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trait_added_supertrait #892

Merged
merged 6 commits into from
Sep 21, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review
mrnossiom committed Sep 20, 2024
commit f6c52f876206bdb73d4398edfefc4c2d03b07e8c
4 changes: 2 additions & 2 deletions src/lints/trait_added_supertrait.ron
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ SemverQuery(
description: "A non-sealed trait added one or more supertraits, which breaks downstream implementations of the trait",
required_update: Major,
lint_level: Deny,
reference_link: None, // TODO
reference_link: Some("doc.rust-lang.org/cargo/reference/semver.html#generic-bounds-tighten"),
obi1kenobi marked this conversation as resolved.
Show resolved Hide resolved
query: r#"
{
CrateDiff {
@@ -54,5 +54,5 @@ SemverQuery(
"zero": 0,
},
error_message: "A non-sealed trait added one or more supertraits, which breaks downstream implementations of the trait",
per_result_error_template: Some("trait {{join \"::\" path}} has gained {{supertrait}} in file {{span_filename}}:{{span_begin_line}}"),
per_result_error_template: Some("trait {{join \"::\" path}} gained {{supertrait}} in file {{span_filename}}:{{span_begin_line}}"),
)