Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendored-openssl feature #324

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Add vendored-openssl feature #324

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15e6867
Add vendored-openssl feature
tonowak Jan 25, 2023
adcf9ef
Add the feature to default features
tonowak Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ignore = "0.4.18"
clap-verbosity-flag = "2.0.0"
log = "0.4.17"
git2 = { version = "0.16.0", default-features = false }
crates-index = { version = "0.19.0", features = ["vendored-openssl"] }
crates-index = { version = "0.19.0" }
human-panic = "1.0.3"
bugreport = "0.5.0"
itertools = "0.10.5"
Expand All @@ -41,3 +41,6 @@ toml = "0.5.9"
[dev-dependencies]
assert_cmd = "2.0"
lazy_static = "1.4.0"

[features]
vendored-openssl = ["crates-index/vendored-openssl"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you still planning on making this feature be default-enabled to preserve the current behavior, or did you change your mind on it again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I forgot to make a commit for making it a default feature. Gimme a sec.

Copy link
Collaborator Author

@tonowak tonowak Jan 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder. adcf9ef