Merge pull request #322 from oat-sa/hotfix/AUT-2713/check-max-when-ma…

…x-equal-min-to-september hotfix/AUT-2713 Choice interaction - Incorrect amount of choices are allowed to be selected if maxChoices = minChoices
oat-sa · Oct 10, 2022 · cc01441 · cc01441
2 parents 00fedda + 138a587
commit cc01441
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@oat-sa/tao-item-runner-qti",
-    "version": "1.4.1",
+    "version": "1.4.2",
     "displayName": "TAO Item Runner QTI",
     "description": "TAO QTI Item Runner modules",
     "files": [

diff --git a/src/qtiCommonRenderer/renderers/interactions/ChoiceInteraction.js b/src/qtiCommonRenderer/renderers/interactions/ChoiceInteraction.js
@@ -248,10 +248,25 @@ const _setInstructions = function _setInstructions(interaction) {
     } else if (min > 1 && min === max) {
         // Multiple Choice: 5. Constraint: Other constraints -> minChoices ≠ Disabled / maxChoices ≠ Disabled -> “You need to select {minChoices = maxChoices value} choices.“
         msg = __('You need to select %s choices', min);
-        instructionMgr.appendInstruction(interaction, msg, function () {
+        instructionMgr.appendInstruction(interaction, msg, function (data) {
             if (_getRawResponse(interaction).length === min) {
                 this.setLevel('success');
-            } else {
+            } else if (_getRawResponse(interaction).length >= max) {
+                this.setMessage(__('Maximum choices reached'));
+                this.update({
+                    level: 'warning',
+                    timeout: 2000,
+                    start: function () {
+                        if (data && data.choice) {
+                            highlightInvalidInput(data.choice);
+                        }
+                    },
+                    stop: function () {
+                        this.setLevel('info');
+                    }
+                });
+                this.setState('fulfilled');
+            }  else {
                 this.reset();
             }
         });