fix: improve calculation of score

oat-sa · Oct 29, 2024 · 551e50d · 551e50d
1 parent 1ee1c95
commit 551e50d
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/qtiItem/helper/maxScore.js b/src/qtiItem/helper/maxScore.js
@@ -104,11 +104,6 @@ export default {
         //try setting the computed normal maximum only if the processing type is known, i.e. 'templateDriven'
         if (scoreOutcome && item.responseProcessing && item.responseProcessing.processingType === 'templateDriven') {
             const interactions = item.getInteractions();
-            const isAllResponseProcessingRulesNone = !interactions.some(interaction => {
-                const responseDeclaration = interaction.getResponseDeclaration();
-                const template = responseHelper.getTemplateNameFromUri(responseDeclaration.template);
-                return template !== 'NONE';
-            });
             maxScore = _.reduce(
                 interactions,
                 function (acc, interaction) {
@@ -159,6 +154,12 @@ export default {
                 }
             }
 
+            const isAllResponseProcessingRulesNone = !interactions.some(interaction => {
+                const responseDeclaration = interaction.getResponseDeclaration();
+                const template = responseHelper.getTemplateNameFromUri(responseDeclaration.template);
+                return template !== 'NONE';
+            });
+
             const outcomesWithExternalScored = customOutcomes.filter(outcome => {
                 return externalScoredValues.includes(outcome.attr('externalScored'));
             });