[AUT-3940] Fix: Single order interaction, moving from order to data-order. #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirylHatalski
requested review from
tikhanovichA,
jsconan,
Karol-Stelmaczonek and
viktar-dzmitryieu-tao
Front-end summary Node 18
|
tikhanovichA
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
viktar-dzmitryieu-tao
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
jsconan
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Quick code review only, looks good.
Do not forget to update the dependency before the merge
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
views/package.json
Outdated
| @@ -9,6 +9,6 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@oat-sa/tao-item-runner": "^1.0.0", | |||
| "@oat-sa/tao-item-runner-qti": "^2.5.1" | |||
| "@oat-sa/tao-item-runner-qti": "oat-sa/tao-item-runner-qti-fe#8a8adb608aa0dc9a21ed4b1bc4e4616c3cd35635" | |||
There was a problem hiding this comment.
- To be updated with the released package before merge
Karol-Stelmaczonek
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
added 13 commits
November 15, 2024 12:38
# Conflicts: # views/js/loader/taoQtiItem.min.js # views/js/loader/taoQtiItem.min.js.map
Version
There are 0 BREAKING CHANGE, 0 feature, 15 fixes |
KirylHatalski
deleted the
fix/AUT-3940/update-order-attr-to-data-order
branch
KirylHatalski
restored the
fix/AUT-3940/update-order-attr-to-data-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Demo:
Before:
Now:
How to test:
Create item with single order interaction, check data-order attr by save or import.
Related PRs: #416, #1329