Update flysystem usage after upgrade #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
This was referenced Oct 10, 2024
augustas
requested review from
yaraslau-kavaliou,
olegkhuss,
mccar and
vbyndych
yaraslau-kavaliou
approved these changes
Oct 18, 2024
| @@ -202,7 +202,7 @@ protected function isInstanceValid($item) | |||
| { | |||
| try { | |||
| $xml = Service::singleton()->getXmlByRdfItem($item); | |||
| } catch (FileNotFoundException $e) { | |||
| } catch (FilesystemException $e) { | |||
There was a problem hiding this comment.
Maybe add some logging here as well?
| foreach ($cssFiles as $key => $file) { | ||
| $cssFiles[$key]['stream'] = $this->getFileSystem()->readStream( | ||
| $stylesheetPath . DIRECTORY_SEPARATOR . $file['basename'] | ||
| ); | ||
| } | ||
|
|
||
| return $cssFiles; | ||
| } catch (FileNotFoundException $exception) { | ||
| } catch (FilesystemException $exception) { |
There was a problem hiding this comment.
I don't really like that we bound to flysystem exception League\Flysystem\FilesystemException inside tao here and in some other places. Maybe it makes sense to create an internal tao exception and catch all Filesystem exceptions here FileSystemWrapperTrait and throw the tao exception instead?
There was a problem hiding this comment.
Thanks, great suggestion, I've updated PRs to catch a filesystem exception defined in our application
This was referenced Oct 25, 2024
…s or changing existing, updated our logic accordingly.
Version❕ Some commits are not using the conventional commits formats. They will be ignored in version management.
There are 0 BREAKING CHANGE, 1 feature, 4 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/REL-1729