Tools/build pdfs only when needed #84
Conversation
and force its generation
…m/oasis-tcs/odata-specs into tools/build-pdfs-only-when-needed
…m/oasis-tcs/odata-specs into tools/build-pdfs-only-when-needed
…m/oasis-tcs/odata-specs into tools/build-pdfs-only-when-needed
…m/oasis-tcs/odata-specs into tools/build-pdfs-only-when-needed
.github/workflows/nodejs.yml
Outdated
| git diff-index --quiet HEAD $dir/*.html $dir/styles/* || npm run pdf $doc | ||
| done | ||
| git add docs/*/*.pdf | ||
| git diff-index --quiet HEAD || ( git commit -m "auto-refreshed" && git push ) |
There was a problem hiding this comment.
A non-selective git diff-index after a selective git add always returns 1, see SAP/odata-vocabularies#271.
An unconditional git push leads to an error when not on a branch (for example, when this check runs after pushing a tag).
There was a problem hiding this comment.
git diff-index is now selective, which should make git push conditional
|
If the CI workflow pushes additional commits to a pull request in this repository, the expected checks do not run after the additional commit, and the pull request cannot be merged (cf. my mail to our admin). Let's wait until this is clarified before we merge improvements to the CI workflow. The improvement to |
…m/oasis-tcs/odata-specs into tools/build-pdfs-only-when-needed
#85, please review & merge |
Fixes #56