Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol conformance: links to sections #77

Merged
merged 55 commits into from
Aug 1, 2023

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 1, 2023

Fixes #52
Fixes #78

  • Conformance: turn "section x.y" text into section references

@ralfhandl ralfhandl added the Protocol Protocol, URL Conventions label Aug 1, 2023
@HeikoTheissen
Copy link
Contributor

Do we need this PR? https://github.com/oasis-tcs/odata-specs/blob/main/docs/odata-protocol/odata-protocol.md already contains the desired section links.

@ralfhandl
Copy link
Contributor Author

@HeikoTheissen I just noticed that we worked in parallel. There are still some unlinked section references:

image

And [section ##with123digits] doesn't work yet:

image

@ralfhandl ralfhandl marked this pull request as ready for review August 1, 2023 14:58
@HeikoTheissen
Copy link
Contributor

And [section ##with123digits] doesn't work yet:

Fixed.

@ralfhandl
Copy link
Contributor Author

@HeikoTheissen please merge if you approve.

HeikoTheissen
HeikoTheissen previously approved these changes Aug 1, 2023
@HeikoTheissen HeikoTheissen merged commit 700e5d8 into main Aug 1, 2023
@HeikoTheissen HeikoTheissen deleted the core/protocol-conformance-links-to-sections branch August 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Protocol Protocol, URL Conventions
Projects
None yet
2 participants