Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change related entity with PUT #1994

Merged
merged 24 commits into from
Oct 16, 2024
Merged

Change related entity with PUT #1994

merged 24 commits into from
Oct 16, 2024

Conversation

HeikoTheissen
Copy link
Contributor

Fixes #1973

ralfhandl
ralfhandl previously approved these changes Sep 12, 2024
ralfhandl
ralfhandl previously approved these changes Sep 12, 2024
@ralfhandl
Copy link
Contributor

Suggestion from @GEricson: use two-column table, with request on the left and resulting entities in the right column.

ralfhandl
ralfhandl previously approved these changes Sep 26, 2024
ralfhandl
ralfhandl previously approved these changes Sep 26, 2024
@ralfhandl
Copy link
Contributor

@HeikoTheissen

  • add headings to requests and responses
  • explicitly mention sloppy references without context

ralfhandl
ralfhandl previously approved these changes Oct 9, 2024
@ralfhandl
Copy link
Contributor

TC 2024-10-09: explicitly state that omitted navigation properties imply no change to the related entities also in PUT requests.

@HeikoTheissen
Copy link
Contributor Author

Change the example to a collection-valued navigation property and point out similarities between contained and non-contained.

@@ -550,75 +554,81 @@ nested delta representation to:
::: example
Example ##ex: When updating an entity with a 4.01 `PUT` request, the target of a
non-containment navigation property can be replaced without changing either the
old or the new targeted entity itself. The targeted entity can then only be
old or the new targeted entity itself. The targeted entity must then be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced without changing either the old or the new targeted entity itself

Foreign-key properties in either the source or the old and new target entities may change as a side-effect.

This text may be misinterpreted as forbidding foreign-key changes.

Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor nits, see comments

ralfhandl
ralfhandl previously approved these changes Oct 10, 2024
@mikepizzo mikepizzo self-requested a review October 16, 2024 15:30
@HeikoTheissen HeikoTheissen merged commit 18b4c1a into main Oct 16, 2024
1 check passed
@HeikoTheissen HeikoTheissen deleted the 1973/put-navprop branch October 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to change a reference without changing the referenced entity in a PUT request
3 participants