ODATA-1506: allow indexing into a collection in a specific order #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthagen
approved these changes
Jan 19, 2022
| @@ -560,11 +560,14 @@ complexColPathExpr = collectionPathExpr | |||
|
|
|||
| collectionPathExpr = count [ OPEN expandCountOption *( SEMI expandCountOption ) CLOSE ] | |||
| / filterExpr [ collectionPathExpr ] | |||
| / OPEN collectionOption *( SEMI collectionOption ) CLOSE [ complexPathExpr ] | |||
There was a problem hiding this comment.
Since the index is not mandatory, the complexPathExpr may come after a collection with more than one entry. Is this OK?
There was a problem hiding this comment.
No, we have to call that out in the prose specification.
HeikoTheissen
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #59 and fixes oasis-tcs/odata-specs#342