Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1761] Format messages for consistency #1438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Nov 25, 2024

  • no full stop at the end of a title
  • no word please (technical writers' rule)
  • unique message ids
  • fix typos
  • add missing context where messages are too short and vague

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

- no full stop at the end of a title
- no word please (technical writers' rule)
- unique message ids
- fix typos
- add missing context where messages are too short and vague
@bocekm bocekm added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. kind/refactor labels Nov 25, 2024
@bocekm bocekm requested a review from a team as a code owner November 25, 2024 22:36
@has-bot
Copy link
Member

has-bot commented Nov 25, 2024

/packit test --labels tier0


Comment generated by an automation.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (3ab1a44) to head (9ababfc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1438   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          72       72           
  Lines        5177     5177           
  Branches      896      896           
=======================================
  Hits         4976     4976           
  Misses        119      119           
  Partials       82       82           
Flag Coverage Δ
centos-linux-7 91.63% <66.66%> (ø)
centos-linux-8 92.49% <66.66%> (ø)
centos-linux-9 92.61% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bocekm bocekm changed the title Format messages for consistency [RHELC-1761] Format messages for consistency Nov 25, 2024
@bocekm bocekm added tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. and removed tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. labels Nov 25, 2024
@has-bot
Copy link
Member

has-bot commented Nov 25, 2024

/packit test --labels sanity


Comment generated by an automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants