Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong file dynamically imported #638

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: wrong file dynamically imported #638

merged 1 commit into from
Feb 13, 2024

Conversation

bavoco
Copy link
Contributor

@bavoco bavoco commented Feb 13, 2024

This may have been missed in db116d1

@bavoco
fix: wrong file dynamicaly imported
d92ff39 
This may have been missed in db116d1
@bavoco bavoco changed the title fix: wrong file dynamicaly imported fix: wrong file dynamically imported Feb 13, 2024
kitsonk
kitsonk approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

Yikes 😱 and all the tests run and it would appear to work because Deno has the node built-ins, so it would just "work" but stupidly slow. 😭 Gotta figure a way to test for that.

@kitsonk kitsonk merged commit 174ba2c into oakserver:main Feb 13, 2024
3 of 4 checks passed
@bavoco bavoco deleted the patch-1 branch February 13, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bavoco @kitsonk