Upgrade Bootstrap to 3.0.0 #3178
Conversation
ghost
assigned 
…Structural changes for mobile, various tweaks throughout.
|
For anyone interested in checking this out already. It's not ready to be reviewed and definitely not ready to be merged. |
|
This should be good for a first review. Reassigning to @simong for review. |
| @@ -22,9 +22,9 @@ | |||
| <div id="admin-header-container"><!-- --></div> | |||
|
|
|||
| <div id="admin-content-container"> | |||
There was a problem hiding this comment.
Is any code looking for <div> specifically? If not, would suggest
<main id="admin-content-container" role="main">
instead for accessibility.
|
Following up to previous comment, looks like bs3 does nothing for rtl languages. Suggest getting the framework in for this support reasonably soon so anyone that does a copy-and-paste doesn't have to go back and redo for rtl |
|
Yeah absolutely, the left hand nav commit was necessary to be able to merge into master though. |
|
Added some comments to the final commits. There also seems to be a merge conflict here. Assigning back to @BP323 for follow-up |
|
Fixed the merge conflict and created a separate issue for the remaining task. |
|
I've created a bootstrap3 branch at https://github.com/oaeproject/3akai-ux/tree/bootstrap3 to be able to send all PRs targeted at my branch to it. |
|
This is in the bootstrap3 branch now. |
Bootstrap 3.0.0 has been released on 19th of August and we should consider upgrading. 2.3.2 is not actively maintained anymore and we are still on 2.3.1.
Edit: by now 3.0.1 has been applied.
Edit 2: by now 3.0.2 has been applied.
Edit 3: by now 3.0.3 has been applied.