-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhysX Split support for PhysX4 #240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update FindPhysX.cmake output to FindPhysX4.cmake - Update PhysX4 package for windows and android to rev6 Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
…ries Signed-off-by: Steve Pham <[email protected]>
…put package Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Unable to build through GHI due to current build scripts for PhysX not related to these changes. |
AMZN-alexpete
approved these changes
Jan 30, 2024
Signed-off-by: Steve Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the PhysX 3rd Party script to support the PhysX 4/5 Split.
FindPhysX.cmake
->FindPhysX4.cmake
FindPhysX4.cmake
to only use static libraries instead of the shared equivalent. This is necessary to prevent collision of the same shared libraries from both versions that have the same name. This will also reduce the 3rd Party package size.rev8