Skip to content

Commit

Permalink
Adding comment as to why compile with warnings not treated as error. …
Browse files Browse the repository at this point in the history
…Assimp's USD support requires compiling TinyUSDZ, which contains compile warnings

Signed-off-by: AMZN-Gene <[email protected]>
  • Loading branch information
AMZN-Gene committed Sep 24, 2024
1 parent 862b0d6 commit eca28ae
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions package-system/assimp/build_assimp_windows.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,28 @@
@rem # cmake expects fowardslashes:
set "DOWNLOADED_PACKAGE_FOLDERS=%DOWNLOADED_PACKAGE_FOLDERS:\=/%"

@rem # /w compiler option. Assimp USD is implemented using TinyUSDZ which, unfortunately, contains compiler warnings
cmake -S temp/src ^
-DBUILD_SHARED_LIBS=OFF ^
-DCMAKE_BUILD_TYPE=Release ^
-DCMAKE_MODULE_PATH="%DOWNLOADED_PACKAGE_FOLDERS%" ^
-DASSIMP_BUILD_ZLIB=OFF ^
-DASSIMP_BUILD_ASSIMP_TOOLS=ON ^
-DASSIMP_BUILD_USD_IMPORTER=ON ^
-DCMAKE_CXX_FLAGS="/EHsc /wd4777 /wd5032" ^
-DCMAKE_CXX_FLAGS="/EHsc /w" ^
temp/src/CMakeLists.txt || exit /b 1
cmake --build temp/src --config release || exit /b 1
cmake --build temp/src --config debug || exit /b 1

@rem # /w compiler option. Assimp USD is implemented using TinyUSDZ which, unfortunately, contains compiler warnings
cmake -S temp/src ^
-DBUILD_SHARED_LIBS=ON ^
-DCMAKE_BUILD_TYPE=Release ^
-DCMAKE_MODULE_PATH="%DOWNLOADED_PACKAGE_FOLDERS%" ^
-DASSIMP_BUILD_ZLIB=OFF ^
-DASSIMP_BUILD_ASSIMP_TOOLS=ON ^
-DASSIMP_BUILD_USD_IMPORTER=ON ^
-DCMAKE_CXX_FLAGS="/EHsc /wd4777 /wd5032" ^
-DCMAKE_CXX_FLAGS="/EHsc /w" ^
temp/src/CMakeLists.txt || exit /b 1
cmake --build temp/src --config release || exit /b 1
cmake --build temp/src --config debug || exit /b 1
Expand Down

0 comments on commit eca28ae

Please sign in to comment.