Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrape examples for docs and quicken the CI #345

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

ChristopherRabotin
Copy link
Member

Summary

  • Scrape the examples since I've started writing them
  • Only build and not run the examples in CI (we don't check the results in CI anyway).

Architectural Changes

No change

New Features

No change

Improvements

No change

Bug Fixes

No change

Testing and validation

Detail the changes in tests, including new tests and validations

Documentation

This will add the examples in the docs!

Building ensures that nothing broke. No need to run them because we don't check the outputs in CI.
Copy link

github-actions bot commented Aug 2, 2024

Visit the preview URL for this PR (updated for commit db53187):

https://nyx-rustdoc--pr345-docs-scrape-examples-5fqgb8jl.web.app

(expires Fri, 09 Aug 2024 22:42:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d8e2a55934352d850c15d11866c39eb2d2e029be

@ChristopherRabotin ChristopherRabotin merged commit cfeafcf into master Aug 2, 2024
6 checks passed
@ChristopherRabotin ChristopherRabotin deleted the docs/scrape-examples branch August 2, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant