check minsize when writing first byte #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzip_test.go
Outdated
| @@ -208,6 +208,51 @@ func TestGzipHandlerNoBody(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestGzipHnalderStream(t *testing.T) { | |||
There was a problem hiding this comment.
did you mean write TestGzipHandlerStream instead of TestGzipHnalderStream
There was a problem hiding this comment.
Woops yep! Also I’m not confident in the fix but the test case reproduces the issue at hand.
Startgzip gets called but not init then subsequently startPlain gets called and then errors
gzip.go
Outdated
| @@ -166,7 +166,7 @@ func (w *GzipResponseWriter) startGzip() error { | |||
| // Initialize and flush the buffer into the gzip response if there are any bytes. | |||
| // If there aren't any, we shouldn't initialize it yet because on Close it will | |||
| // write the gzip header even if nothing was ever written. | |||
| if len(w.buf) > 0 { | |||
| if len(w.buf) >= w.minSize { | |||
There was a problem hiding this comment.
This seems to introduce another issue found in the failing test case due to the reason previously mentioned. This is preventing w.init() from being called. Also, the following conditional check len(w.buf) >= w.minSize is already made in the write function.
|
I removed the invalid fix, but left the test case up there showing the issue we are running into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where writing and flushing a zero byte write would cause startGzip() to run but not write, and then on subsequent writes call startPlain, resulting in invalid header errors