Fix if empty getSetting of item-notes-folder #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this merged? I'm having the same problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I start using this plugin to sync obsidian with my pocket account.
As I am not use any special folder for Pocket note, I leave the correspondent setting as default (blank).
But I found that the initial configuration will get error every time this plugin try to create a new note from a pocket link.
Reproduce step:
So I start digging locally, and create this fix. It is working well now using my fork.
Additional Notes
Along the way of fixing I found wrong reference import to "utils" module, which apparently in the code base the module name is actually "Utils". I don't know if this is a typo or something else but I fix it nonetheless.
Do you think this fix is relevant or not? probably you could merge it to the upstream.
PS: Nice works from you, I will probably use this plugin in daily basis and maybe will help along the way.