Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch locations model to use json field instead of postgis field #5771

Closed
wants to merge 1 commit into from

Conversation

norkans7
Copy link

@norkans7 norkans7 commented Jan 8, 2025

Part 1 towards removing use of postgis

Other PRs will add migrations to migrate existing DB objects to the new models and stop using the old models

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.99%. Comparing base (5bac749) to head (45cb889).

Files with missing lines Patch % Lines
temba/locations/models.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #5771      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          443      444       +1     
  Lines        25089    25124      +35     
===========================================
+ Hits         25089    25123      +34     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -178,3 +178,50 @@ def create(cls, org, user, boundary, name):

class Meta:
indexes = [models.Index(Upper("name"), name="boundaryaliases_by_name")]


class AdminLocation(MPTTModel, models.Model):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just Location ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started with AdminBound but I can call that Location for sure

@norkans7
Copy link
Author

norkans7 commented Jan 9, 2025

Replaced by #5775

@norkans7 norkans7 closed this Jan 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants