Include stack explicitly in panic recovery log

nyaruka · Sep 30, 2024 · a4a5665 · a4a5665
1 parent ff99cb8
commit a4a5665
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/utils/crons/cron.go b/utils/crons/cron.go
@@ -121,7 +121,7 @@ func fireCron(rt *runtime.Runtime, name string, cronFunc Function, timeout time.
 		if panicVal := recover(); panicVal != nil {
 			debug.PrintStack()
 
-			slog.Error("panic running cron", "cron", name, "panic", panicVal)
+			slog.Error("panic running cron", "cron", name, "value", panicVal, "stack", debug.Stack())
 		}
 	}()
 

diff --git a/web/middleware.go b/web/middleware.go
@@ -41,7 +41,7 @@ func panicRecovery(next http.Handler) http.Handler {
 			if panicVal := recover(); panicVal != nil {
 				debug.PrintStack()
 
-				slog.Error("panic in web handling", "url", r.URL.String(), "panic", panicVal)
+				slog.Error("panic in web handling", "url", r.URL.String(), "value", panicVal, "stack", debug.Stack())
 
 				http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
 			}

diff --git a/workers.go b/workers.go
@@ -163,7 +163,7 @@ func (w *Worker) handleTask(task *queues.Task) {
 		if panicVal := recover(); panicVal != nil {
 			debug.PrintStack()
 
-			log.Error("panic handling task", "task", string(task.Task), "panic", panicVal)
+			log.Error("panic handling task", "task", string(task.Task), "value", panicVal, "stack", debug.Stack())
 		}
 
 		// mark our task as complete