Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait expiration changes #1302

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Wait expiration changes #1302

merged 3 commits into from
Jan 24, 2025

Conversation

rowanseymour
Copy link
Member

  • Use time.Duration internally for flow wait expire value
  • Add fallback values for expires after for messaging and voice flow types
  • Make expires_on non-nil on waits

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.75%. Comparing base (1bba8cc) to head (f7aee86).

Files with missing lines Patch % Lines
flows/definition/flow.go 82.60% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         276      276           
  Lines       21332    21334    +2     
=======================================
+ Hits        17440    17442    +2     
  Misses       3318     3318           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit ca47382 into main Jan 24, 2025
7 checks passed
@rowanseymour rowanseymour deleted the expires_changes branch January 24, 2025 23:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant