Allow categories up to 64 chars, disallow empty categories #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
longer_categories
branch
from
773c397 to
e503134
Compare
rowanseymour
commented
Dec 26, 2024
| @@ -195,7 +195,7 @@ type baseRouterEnvelope struct { | |||
| Type string `json:"type" validate:"required"` | |||
| Wait json.RawMessage `json:"wait,omitempty"` | |||
| ResultName string `json:"result_name,omitempty" validate:"omitempty,result_name"` | |||
| Categories []json.RawMessage `json:"categories,omitempty" validate:"required,min=1,dive,result_category"` | |||
There was a problem hiding this comment.
this is wrong.. and not sure how it's currently working since each category at this point is just json.RawMessage
rowanseymour
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 81.76% 81.74% -0.02%
==========================================
Files 276 276
Lines 21339 21326 -13
==========================================
- Hits 17447 17434 -13
Misses 3318 3318
Partials 574 574 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.