Merge pull request #1198 from nyaruka/trim_attachments

Trim whitespace from evaluated message attachments
nyaruka · Nov 30, 2023 · d6a67ab · d6a67ab
2 parents c038a35 + ca2d1fd
commit d6a67ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/flows/actions/base.go b/flows/actions/base.go
@@ -99,6 +99,7 @@ func (a *baseAction) evaluateMessage(run flows.Run, languages []i18n.Language, a
 		if err != nil {
 			logEvent(events.NewError(err))
 		}
+		evaluatedAttachment = strings.TrimSpace(evaluatedAttachment)
 		if evaluatedAttachment == "" {
 			logEvent(events.NewErrorf("attachment text evaluated to empty string, skipping"))
 			continue

diff --git a/flows/actions/testdata/send_msg.json b/flows/actions/testdata/send_msg.json
@@ -111,7 +111,7 @@
             "uuid": "ad154980-7bf7-4ab8-8728-545fd6378912",
             "text": "Hi there",
             "attachments": [
-                "@(\"\")"
+                "@(\" \")"
             ],
             "quick_replies": [
                 "@(\"\")"