Do not log EX MT response check error #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 74.56% 74.56%
=======================================
Files 112 112
Lines 13274 13274
=======================================
Hits 9898 9898
Misses 2655 2655
Partials 721 721 ☔ View full report in Codecov by Sentry. |
rowanseymour
reviewed
Jan 9, 2025
handlers/external/handler.go
Outdated
| @@ -366,7 +366,7 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen | |||
| } | |||
|
|
|||
| if responseCheck != "" && !strings.Contains(string(respBody), responseCheck) { | |||
| return courier.ErrResponseUnexpected | |||
| return courier.ErrFailedWithReason("mt-response-check", fmt.Sprintf("response not containing '%s'", responseCheck)) | |||
There was a problem hiding this comment.
Hmm I think we want basically the same as ErrResponseUnexpected but not logged.. so maybe just a new error constant:
var ErrResponseUnexpectedUnlogged error = &SendError{
msg: "response not expected values",
retryable: false,
loggable: false,
clogCode: "response_unexpected",
clogMsg: "Response doesn't match expected values.",
}
norkans7
force-pushed
the
EX-response-check
branch
from
9de14f4 to
b73c789
Compare
rowanseymour
requested changes
Jan 9, 2025
sender.go
Outdated
| @@ -110,6 +110,15 @@ var ErrResponseUnexpected error = &SendError{ | |||
| clogMsg: "Response doesn't match expected values.", | |||
| } | |||
|
|
|||
| // ErrResponseUnexpectedUnlogged should be returned when channel response doesn't match what we expect and unlogged | |||
There was a problem hiding this comment.
// ErrResponseUnexpectedUnlogged is same as ErrResponseUnexpected without logging so better for channels where response check is user configured.
norkans7
force-pushed
the
EX-response-check
branch
from
b73c789 to
c1cc157
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.