fix(run): pass cli args to nw process

[ayushmanchhabra]

Fixes: #150

[ayushmanchhabra]

I am able to verify that arguments are passed to nw by creating the UserData dir in a custom location. Executing npm run demo creates it under test/fixture/user-data

[ayushmanchhabra]

@ronny1982 ping, do you wanna test this PR?

Steps to test:

1. npm uninstall nw
2. npm install https://github.com/nwjs/npm-installer/tree/dev-150-2

[ronny1982]

The command-line help is incorrect

# nw --help
(node:13867) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Usage: nw [options] [app]

Options:
  --version <string>
  --flavor <flavor>
  --platform <platform>
  --arch <arch>
  --cacheDir <cacheDir>
  -h, --help             display help for command

The [options] are listed before [app], but it should be vice versa.
There is also a JSON import warning shown.

[ronny1982]

If no cache directory is present, path.resolve('.', 'node_modules', 'nw') is used in parse.js as default.
Since path.resolve uses the working directory this may lead to invalid results (e.g., when using NPM workspaces).

Maybe it would be more reliable to use the application path itself as base e.g., something like path.resolve(path.dirname(process.argv[1]), '..', 'nw').

[ronny1982]

@ronny1982 ping, do you wanna test this PR?

Steps to test:

1. npm uninstall nw
2. npm install https://github.com/nwjs/npm-installer/tree/dev-150-2

Tested locally and added feedback/findings related to command-line args processing in the comment section.

[ayushmanchhabra]

If no cache directory is present, path.resolve('.', 'node_modules', 'nw') is used in parse.js as default. Since path.resolve uses the working directory this may lead to invalid results (e.g., when using NPM workspaces).

Maybe it would be more reliable to use the application path itself as base e.g., something like path.resolve(path.dirname(process.argv[1]), '..', 'nw').

Not sure how nw would fail in a workspace - could you give an example/repro? Btw, this is should be addressed in another PR.

[ronny1982]

Not sure how nw would fail in a workspace - could you give an example/repro? Btw, this is should be addressed in another PR.

Created #157

[ayushmanchhabra]

Although unknown args are now accepted, there are a few issues:

1. setting --log-level=verbose does not pipe logs to stdout
2. log-level values are actually from 0 to 3 but when setting to a valid number, it still does not pipe to stdout

[ronny1982]

Implementation looks good to me.
Functionality was not further tested/verified.

[ronny1982]

Although unknown args are now accepted, there are a few issues:

1. setting --log-level=verbose does not pipe logs to stdout
2. log-level values are actually from 0 to 3 but when setting to a valid number, it still does not pipe to stdout

The issue was focusing on passing args to the NW.js app, which is solved by this PR.
I probably picked a bad example which implies further functionality, this was not intended.
Could probably have used a more appropriate example such as --my-app-theme=darkmode.