update patches to //tools/licenses.py #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerwang
force-pushed
the
nw25
branch
2 times, most recently
from
0b63552 to
1d17e7f
Compare
rogerwang
force-pushed
the
nw25
branch
4 times, most recently
from
2f4783c to
223521f
Compare
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
Bug: 774814 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I442f55b957017119b5241993ee0f90ae63a86557 Reviewed-on: https://chromium-review.googlesource.com/729126 Reviewed-by: Andrei Kapishnikov <[email protected]> Commit-Queue: Misha Efimov <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#510231}(cherry picked from commit d5ccb43) Reviewed-on: https://chromium-review.googlesource.com/729380 Cr-Commit-Position: refs/branch-heads/3239@{#94} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
GnorTech
pushed a commit
that referenced
this pull request
Dec 16, 2017
GeoNotifier's underlying callback functions are made alive by its execution context. Thus, when the execution context is gone, the underlying callback functions are also gone. Also, it doesn't make sense anyway to invoke a callback when its own execution context is already gone. Thus, this patch adds the check of the execution context before doing anything. [email protected] (cherry picked from commit f7c95d3) Bug: 788975 Change-Id: I39bcbcbbe9df201924427f9d2341ba6724b5b79c Reviewed-on: https://chromium-review.googlesource.com/798996 Commit-Queue: Yuki Shiino <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Reviewed-by: Hitoshi Yoshida <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#520909} Reviewed-on: https://chromium-review.googlesource.com/816639 Reviewed-by: Yuki Shiino <[email protected]> Cr-Commit-Position: refs/branch-heads/3282@{#94} Cr-Branched-From: 5fdc0fa-refs/heads/master@{#520840}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
With display zoom a wide range of device scale factors can now be set as for a given device. Sometimes a value can lead to a failure in the pixel snapping check. This patch increases the threshold for these checks. Bug: 790723 Change-Id: I21ae6711f608b9f6bc99efd47d0c8466f03722eb Component: Dip Util, Pixel Snapping, Reviewed-on: https://chromium-review.googlesource.com/884361 Commit-Queue: Malay Keshav <[email protected]> Reviewed-by: Scott Violet <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#531966}(cherry picked from commit d85e91c) Reviewed-on: https://chromium-review.googlesource.com/887283 Reviewed-by: Malay Keshav <[email protected]> Cr-Commit-Position: refs/branch-heads/3325@{#94} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
Events would get marked as consumed when on top of the resize controller. Deal with that situation so that we allow the resize to occur on disabled form controls. BUG=762709 [email protected] (cherry picked from commit 9e011ce) Change-Id: I17f8ae25541f9e4665d4a4bbcfef9e719f12f454 Reviewed-on: https://chromium-review.googlesource.com/951911 Reviewed-by: Navid Zolghadr <[email protected]> Commit-Queue: Dave Tapuska <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#541234} Reviewed-on: https://chromium-review.googlesource.com/955742 Reviewed-by: Dave Tapuska <[email protected]> Cr-Commit-Position: refs/branch-heads/3359@{#94} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
This experiment also resets the kHasSeenWin10Promo pref. Bug: 798612 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie9bb7d1af812a96f11058c928cb32fa6491d96db Reviewed-on: https://chromium-review.googlesource.com/1017660 Reviewed-by: Patrick Monette <[email protected]> Cr-Commit-Position: refs/branch-heads/3396@{#94} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
…old start We currently have a bug in the new horizontal tab switcher on Android where if tabs get reloaded after a cold start, the snap distance is not set properly, so the snapping behavior doesn't work properly. The fix is to update the snap distance in NonOverlappingStack#notifySizeChanged() in addition to contextChanged() (apparently when reloading tabs, contextChanged() is not called again after the StackLayout's size is properly set). Bug: 846961, 831359 Change-Id: I8c1be9f38889d6d1c45adefeb51af30d6a8bb4e3 Reviewed-on: https://chromium-review.googlesource.com/1081091 Reviewed-by: Matthew Jones <[email protected]> Commit-Queue: Ryan Landay <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#563647}(cherry picked from commit a73bfcd) Reviewed-on: https://chromium-review.googlesource.com/1082852 Reviewed-by: Ryan Landay <[email protected]> Cr-Commit-Position: refs/branch-heads/3440@{#94} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
…w(). Implement the currently unimplemented (on mac) NativeWidget:: SetVisibilityAnimationTransition() for this. Autofill uses this but not constrained windows. Constrained windows on aura platforms have bespoke animation suppression code, which is currently different to the desired behavior on Mac (i.e. the very first "show" should animate). Consolidate some of the animation logic in MacViews Widgets. [email protected] (cherry picked from commit 7f4f6cf) Bug: 767743 Change-Id: If49d139a66873e896e68030f69efdaa81a8dc948 Reviewed-on: https://chromium-review.googlesource.com/1146408 Reviewed-by: Michael Wasserman <[email protected]> Reviewed-by: Sidney San Martín <[email protected]> Commit-Queue: Trent Apted <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#577343} Reviewed-on: https://chromium-review.googlesource.com/1150016 Reviewed-by: Trent Apted <[email protected]> Cr-Commit-Position: refs/branch-heads/3497@{#94} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
This regressed in crrev.com/c/1081370 due to a combination of 1. Over-eager refactoring 2. Phantom tests that didn't actually test the functionality. The regression is reverted here and the test for the feature is fixed so it actually triggers the behavior. [email protected] Bug: 880829 Change-Id: Ic27a0718de685acea00af0b5d88e249b5fb0a6c2 Reviewed-on: https://chromium-review.googlesource.com/1206674 Reviewed-by: Josh Karlin <[email protected]> Commit-Queue: Charlie Harrison <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#588930}(cherry picked from commit d27345d) Reviewed-on: https://chromium-review.googlesource.com/1211544 Reviewed-by: Charlie Harrison <[email protected]> Cr-Commit-Position: refs/branch-heads/3538@{#94} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
Only happens where there are 2+ users (ie, user list is used). OnImageDecoded is supposed to use the animation playback type that was set in SetAnimationEnabled. However, UpdateForUser calls SetImage which updates image_->playback() to kFirstFrameOnly. This means that OnImageDecoded cannot use image_->playback() as the playback type set by SetAnimationEnabled. [email protected] (cherry picked from commit 484a185) Bug: 894771 Change-Id: I47ac6daa1e8780e58abdabf59a7642ca4b9dcc43 Reviewed-on: https://chromium-review.googlesource.com/c/1277699 Reviewed-by: Wenzhao (Colin) Zang <[email protected]> Commit-Queue: Jacob Dufault <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#599731} Reviewed-on: https://chromium-review.googlesource.com/c/1287034 Reviewed-by: Jacob Dufault <[email protected]> Cr-Commit-Position: refs/branch-heads/3578@{#94} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
Also adding a couple of tests. [email protected] Bug: 909978 Change-Id: Ic63d5b35a1112c86a3430f4c52f476444b53c666 Reviewed-on: https://chromium-review.googlesource.com/c/1355879 Reviewed-by: Tommy Nyquist <[email protected]> Reviewed-by: Sky Malice <[email protected]> Reviewed-by: Becky Zhou <[email protected]> Commit-Queue: Brandon Wylie <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#613743}(cherry picked from commit 902b7c2) Reviewed-on: https://chromium-review.googlesource.com/c/1364166 Reviewed-by: Brandon Wylie <[email protected]> Cr-Commit-Position: refs/branch-heads/3626@{#94} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
webView:didCommitNavigation: used to assume that pending item is always valid and crashed on dereferencing null pointer. Pending item should never be null inside webView:didCommitNavigation: but existing ownership model is incorrect, so pending item could be distroyed before committing. This CL adds checks before dereferencing pending item to avoid the crash. The real fix could be implemented by storing pending item in NavigationContext object (crbug.com/925304). Bug: 676458 Change-Id: Idf60e60cbe98111e8fed5d2903ae8bc8b8df3d90 Reviewed-on: https://chromium-review.googlesource.com/c/1444953 Reviewed-by: Justin Cohen <[email protected]> Commit-Queue: Eugene But <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#627509}(cherry picked from commit 010e2b2) Reviewed-on: https://chromium-review.googlesource.com/c/1448521 Reviewed-by: Kariah Davis <[email protected]> Cr-Commit-Position: refs/branch-heads/3683@{#94} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
Since for incognito profiles, the downloads are not required to be resumed after the profile is closed, we need not schedule background tasks for download service. This CL cleans up spinning up download service from the background task. Bug: 906895 Change-Id: If11e1a548c37922ada6893a126963a229bc147ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517158 Reviewed-by: Min Qin <[email protected]> Reviewed-by: David Trainor <[email protected]> Commit-Queue: Shakti Sahu <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#640082}(cherry picked from commit fda54f096008875857b4ab509e5e6990873e6929) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521629 Reviewed-by: Shakti Sahu <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#94} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.