Removing erroneous dizque_instance causing add_fillers to fail #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within Fillers Model, add_fillers had a call to expand_custom_show_items which included programs and dizque_instance, but expand_custom_show_items only accepts programs - dizque_instance not accepted here (see https://dizquetv.readthedocs.io/en/latest/documentation.html#dizqueTV.dizquetv.API.expand_custom_show_items )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within Fillers Model, add_fillers had a call to expand_custom_show_items which included programs and dizque_instance, but expand_custom_show_items only accepts programs - dizque_instance not accepted here (see https://dizquetv.readthedocs.io/en/latest/documentation.html#dizqueTV.dizquetv.API.expand_custom_show_items )
--
Current usage of add_fillers results in error
Traceback (most recent call last):
File "/opt/bfscript/playlist_to_filler.py", line 93, in
fillerlist.add_fillers(fillers=to_add)
File "/usr/local/lib/python3.8/dist-packages/dizqueTV/decorators.py", line 19, in inner
return func(obj, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/dizqueTV/models/fillers.py", line 180, in add_fillers
fillers = self._dizque_instance.expand_custom_show_items(
TypeError: expand_custom_show_items() got an unexpected keyword argument 'dizque_instance'