Set content type when Firefox #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -135,7 +135,7 @@ var ics = function(uidDomain, prodId) { | |||
| // Since some calendars don't add 0 second events, we need to remove time if there is none... | |||
| var start_time = ''; | |||
| var end_time = ''; | |||
| if (start_hours + start_minutes + start_seconds + end_hours + end_minutes + end_seconds != 0) { | |||
| if (start_hours + start_minutes + start_seconds + end_hours + end_minutes + end_seconds !== 0) { | |||
There was a problem hiding this comment.
That's wrong because the variables are strings. Your code will never enter the if clause. A (one possible) correct fix is: !== "000000000000". I fixed it like this: michael-maltsev@f34a6ed
There was a problem hiding this comment.
@michael-maltsev Thanks for letting me know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS:
When using the
downloadmethod generated files will be interpreted as plain text(txt) files in Firefox.Thus when the download dialog opens, the suggested application to open the file will be notepad/textedit.
This PR adds the missing
typein the saveAs call.https://github.com/eligrey/FileSaver.js#examples
Afterwards when the download dialog opens,
the suggested application to open the file will be ical/outlook.