Software sometimes does not terminate after quitting. Fixes #21.

nwaldispuehl · Feb 7, 2017 · 914c753 · 914c753
1 parent fe272e8
commit 914c753
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/intervalmusiccompositor.build/documentation/retorte_IntervalMusicCompositor_changelog.txt b/intervalmusiccompositor.build/documentation/retorte_IntervalMusicCompositor_changelog.txt
@@ -6,6 +6,7 @@ retorte laboratories (retorte.ch) IntervalMusicCompositor change log
 FIX         Adapted version check URL to new server address.
 ADD  #20    Check update dialog contains link to latest software version download.
 FIX  #19    Changing/writing BPM not possible.
+FIX  #21    Software sometimes does not terminate after quitting.
 
 
 2016-09-23  2.6.3

diff --git a/...Ui/src/main/java/ch/retorte/intervalmusiccompositor/ui/updatecheck/UpdateCheckDialog.java b/...Ui/src/main/java/ch/retorte/intervalmusiccompositor/ui/updatecheck/UpdateCheckDialog.java
@@ -13,6 +13,7 @@
 import javafx.scene.text.Text;
 import javafx.stage.Stage;
 
+import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 
 
@@ -74,7 +75,10 @@ private void updateAlertPaneWith(Node node) {
   }
 
   private void startVersionCheck() {
-    Executors.newSingleThreadExecutor().submit(new VersionCheckTask());
+    // We are creating a thread executor, but shutting it down right away so it gets collected once the task finishes.
+    ExecutorService executorService = Executors.newSingleThreadExecutor();
+    executorService.submit(new VersionCheckTask());
+    executorService.shutdown();
   }
 
   private Hyperlink downloadHyperlink() {