-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Machine Readable walletsrecovery.json file #138
base: master
Are you sure you want to change the base?
Conversation
Machine readable file for automated wallet recovery tools.
I believe this format covers all the various options.
First proposed version with just hardware wallets.
Looks fine, for now I think we should just mirror everything that us on the markdown.
it doesn't restrict 48 supported.
Would be great but really hard to maintain.
for now KISS, lets just mirror. IF this website becomes JSON driven that we can have more options. |
Ok, I will move forward with adding the rest of the wallets from the markdown version. I'm not sure I understand your answer on m/48'. Thanks |
You did it correctly :) |
May I suggest to not "mirror" stuff but to migrate to something more advanced altogether? For walletscrutiny.com I use Jekyll and I love it. And GitHub.io also loves Jekyll but (so do I) compiling Jekyll is trivial, too ;) I hadn't known about Jekyll before starting walletscrutiny so at the risk of explaining what you all know anyway (after all Jekyll is a dinosaur), let me show you:
In summary, if walletsrecovery wants to provide the data in a more accessible way, it should use yaml and not JSON ;) Instead of a long file containing
we would have a file
Anything in the |
That's sounds like a very interesting solution. Obviously this is up to @nvk on how to proceed. I'm just about finished with the JSON file, so I will do another pull request on that. How to proceed going forward can be discussed with the JSON file available to look at. |
I like the idea still struggling with keeping this site simple stupid so that is always up to date. The json file is great, but someone will need to keep it up to date. And I don't have bandwidth to code this up as a dynamic site based on the json doc. Data duplication is never a good idea. :/ |
I'd donate $100 to get this migration done. I could ask a guy who helped me with WalletScrutiny.com who will probably do this for that price. I'd prefer to fund a bitcoiner though, so if anybody wants to volunteer, ... the bounty stands. As Jekyll is already being thrown at the code provided by GitHub, the job description would be: Migrate data from the four tables into individual files in the
To have all wallets in one folder, a discriminator would probably be good and to make it as easy to edit for new people, comments should be added, too. A fan of a new wallet should easily be able to copy an existing file and figure it out from there.
|
This is an initial attempt at a machine readable json file for bitcoin wallet recovery programs to have access to.
The following known issues need to be addressed in this version.
Only the hardware wallets are included
ColdCard's m/48' derivation path has a script type that I could not verify..
Should there be an array of firmware versions?
For example the CoboVault introduced PSBT in firmware 1.3.0 but the table says it's not supported.
If the array is added, which fields should be in the array and which should be single keys per wallet?