fix(path): make find_upwards() search root #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapling
reviewed
Aug 30, 2023
zapling
reviewed
Aug 30, 2023
|
@Conni2461 do you have any additional input on this? Would love to see this issue resolved. |
shreve
changed the title
The previous implementation of `Path:find_upwards()` used the loop condition `folder ~= root` to bound the search which meant the root directory would never be searched. This commit instead breaks the `while true` loop after searching the root directory. The function now also returns `nil` rather than a blank string to indicate that the search has failed. Finally, this commit adds specs for the function.
shreve
changed the title
|
@Conni2461 I got scooped by #562, but their implementation was still broken in a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior implementation had several implementation issues which caused an infinite loop if the search turned up empty.This new implementation corrects the bounds check to stop searching once we've searched everywhere we can, and properly searches the root directory.