helm 2.14 -> 2.17; succeeded pod is always valid

nuvo · May 5, 2021 · f0ae454 · f0ae454
1 parent 419bb86
commit f0ae454
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.9
 
-ARG HELM_VERSION=v2.14.0
+ARG HELM_VERSION=v2.17.0
 ARG HELM_OS_ARCH=linux-amd64
 
 RUN apk --no-cache add ca-certificates git bash curl jq \
@@ -20,7 +20,8 @@ WORKDIR /home/orca
 
 ENV HELM_HOME /home/orca/.helm
 
-RUN helm init -c \
+RUN helm init --stable-repo-url=https://charts.helm.sh/stable --client-only \
+  && helm repo add "stable" "https://charts.helm.sh/stable" \
   && helm plugin install https://github.com/chartmuseum/helm-push
 
-CMD ["orca"]
+CMD ["orca"]
diff --git a/pkg/utils/validate.go b/pkg/utils/validate.go
@@ -55,7 +55,7 @@ func validatePods(name, kubeContext string, envValid bool) (bool, error) {
 		if phase == "Running" {
 			continue
 		}
-		if phase == "Succeeded" && pod.OwnerReferences[0].Kind == "Job" {
+		if phase == "Succeeded" {
 			continue
 		}
 		log.Printf("pod %s is in phase \"%s\"", pod.Name, phase)