Skip to content

WIP: add Orchard note commitment tree size to block metadata. #2164

WIP: add Orchard note commitment tree size to block metadata.

WIP: add Orchard note commitment tree size to block metadata. #2164

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Clippy (MSRV) failed Oct 25, 2023 in 0s

Clippy (MSRV)

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.65.0 (897e37553 2022-11-02)
  • cargo 1.65.0 (4bc8f24d3 2022-10-20)
  • clippy 0.1.65 (897e375 2022-11-02)

Annotations

Check failure on line 187 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

this function takes 2 arguments but 1 argument was supplied

error[E0061]: this function takes 2 arguments but 1 argument was supplied
    --> zcash_client_sqlite/src/lib.rs:187:9
     |
187  |         wallet::block_max_scanned(self.conn.borrow())
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^-------------------- an argument of type `&_` is missing
     |
note: function defined here
    --> zcash_client_sqlite/src/wallet.rs:1117:15
     |
1117 | pub(crate) fn block_max_scanned<P: consensus::Parameters>(
     |               ^^^^^^^^^^^^^^^^^
1118 |     conn: &rusqlite::Connection,
     |     ---------------------------
1119 |     params: &P,
     |     ----------
help: provide the argument
     |
187  |         wallet::block_max_scanned(self.conn.borrow(), /* value */)
     |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 183 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

this function takes 2 arguments but 1 argument was supplied

error[E0061]: this function takes 2 arguments but 1 argument was supplied
    --> zcash_client_sqlite/src/lib.rs:183:9
     |
183  |         wallet::block_fully_scanned(self.conn.borrow())
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------- an argument of type `&_` is missing
     |
note: function defined here
    --> zcash_client_sqlite/src/wallet.rs:1065:15
     |
1065 | pub(crate) fn block_fully_scanned<P: consensus::Parameters>(
     |               ^^^^^^^^^^^^^^^^^^^
1066 |     conn: &rusqlite::Connection,
     |     ---------------------------
1067 |     params: &P,
     |     ----------
help: provide the argument
     |
183  |         wallet::block_fully_scanned(self.conn.borrow(), /* value */)
     |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 179 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

this function takes 3 arguments but 2 arguments were supplied

error[E0061]: this function takes 3 arguments but 2 arguments were supplied
    --> zcash_client_sqlite/src/lib.rs:179:9
     |
179  |         wallet::block_metadata(self.conn.borrow(), height)
     |         ^^^^^^^^^^^^^^^^^^^^^^                     ------ an argument of type `&_` is missing
     |
note: function defined here
    --> zcash_client_sqlite/src/wallet.rs:1035:15
     |
1035 | pub(crate) fn block_metadata<P: consensus::Parameters>(
     |               ^^^^^^^^^^^^^^
1036 |     conn: &rusqlite::Connection,
     |     ---------------------------
1037 |     params: &P,
     |     ----------
1038 |     block_height: BlockHeight,
     |     -------------------------
help: provide the argument
     |
179  |         wallet::block_metadata(self.conn.borrow(), /* value */, height)
     |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 607 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

this function takes 2 arguments but 1 argument was supplied

error[E0061]: this function takes 2 arguments but 1 argument was supplied
    --> zcash_client_sqlite/src/wallet.rs:607:9
     |
607  |         block_fully_scanned(conn)?.map_or(birthday_height - 1, |m| m.block_height());
     |         ^^^^^^^^^^^^^^^^^^^------ an argument of type `&_` is missing
     |
note: function defined here
    --> zcash_client_sqlite/src/wallet.rs:1065:15
     |
1065 | pub(crate) fn block_fully_scanned<P: consensus::Parameters>(
     |               ^^^^^^^^^^^^^^^^^^^
1066 |     conn: &rusqlite::Connection,
     |     ---------------------------
1067 |     params: &P,
     |     ----------
help: provide the argument
     |
607  |         block_fully_scanned(conn, /* value */)?.map_or(birthday_height - 1, |m| m.block_height());
     |                            ~~~~~~~~~~~~~~~~~~~