Skip to content

zcash_client_backend: Factor out common note decryption from `scan_bl… #2493

zcash_client_backend: Factor out common note decryption from `scan_bl…

zcash_client_backend: Factor out common note decryption from `scan_bl… #2493

Triggered via push February 23, 2024 05:01
Status Failure
Total duration 29m 22s
Artifacts

ci.yml

on: push
Matrix: build-latest
Matrix: build-nodefault
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 5 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
Rustfmt
Process completed with exit code 1.
redundant slicing of the whole range: zcash_client_backend/src/scanning.rs#L733
error: redundant slicing of the whole range --> zcash_client_backend/src/scanning.rs:733:55 | 733 | batch::try_compact_note_decryption(&ivks, &decoded[..]) | ^^^^^^^^^^^^ help: use the original value instead: `decoded` | = note: `-D clippy::redundant-slicing` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
this function has too many arguments (13/7): zcash_client_backend/src/scanning.rs#L653
error: this function has too many arguments (13/7) --> zcash_client_backend/src/scanning.rs:653:1 | 653 | / fn find_notes< 654 | | M, 655 | | D: BatchDomain, 656 | | SK: ScanningKey<Note = D::Note>, ... | 686 | | Vec<(NoteCommitment, Retention<BlockHeight>)>, 687 | | ) { | |_^ | = note: `-D clippy::too-many-arguments` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
redundant slicing of the whole range: zcash_client_backend/src/scanning.rs#L733
error: redundant slicing of the whole range --> zcash_client_backend/src/scanning.rs:733:55 | 733 | batch::try_compact_note_decryption(&ivks, &decoded[..]) | ^^^^^^^^^^^^ help: use the original value instead: `decoded` | = note: `-D clippy::redundant-slicing` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
this function has too many arguments (13/7): zcash_client_backend/src/scanning.rs#L653
error: this function has too many arguments (13/7) --> zcash_client_backend/src/scanning.rs:653:1 | 653 | / fn find_notes< 654 | | M, 655 | | D: BatchDomain, 656 | | SK: ScanningKey<Note = D::Note>, ... | 686 | | Vec<(NoteCommitment, Retention<BlockHeight>)>, 687 | | ) { | |_^ | = note: `-D clippy::too-many-arguments` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
Clippy (MSRV)
Clippy had exited with the 101 exit code
Clippy (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
protobuf consistency
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: supplypike/setup-bin@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/