Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt X509Credential validation, use nested JSON structure #3640

Merged
merged 1 commit into from
Jan 7, 2025
Merged

adapt X509Credential validation, use nested JSON structure #3640

merged 1 commit into from
Jan 7, 2025

Conversation

woutslakhorst
Copy link
Member

@woutslakhorst woutslakhorst commented Jan 7, 2025 •
edited
Loading

closes #3639

validates:

"credentialSubject": {
  "san": {
    "otherName":"example.com"
  }
}

instead of:

"credentialSubject": {
  "san:otherName":"example.com"
}

gerardsn
gerardsn approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woutslakhorst woutslakhorst merged commit b8e7041 into master Jan 7, 2025
8 of 9 checks passed
@woutslakhorst woutslakhorst deleted the feature/3639/update_x509credential_validator branch January 7, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardsn gerardsn gerardsn approved these changes

@reinkrul reinkrul Awaiting requested review from reinkrul reinkrul is a code owner

@stevenvegt stevenvegt Awaiting requested review from stevenvegt stevenvegt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update X509Credential validation to latest RFC
2 participants
@woutslakhorst @gerardsn