Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless test to fix data race #3625

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Remove useless test to fix data race #3625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions storage/session_memcached_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ import (
"github.com/stretchr/testify/require"
)

func TestNewMemcachedSessionDatabase(t *testing.T) {
db := memcachedTestDatabase(t)

assert.NotNil(t, db)
}

func TestNewMemcachedSessionDatabase_GetStore(t *testing.T) {
db := memcachedTestDatabase(t)

Expand Down Expand Up @@ -177,6 +171,10 @@ func memcachedTestServer(t *testing.T) *minimemcached.MiniMemcached {
t.Fatal(err)
}
t.Cleanup(func() {
// Note on DATA RACE
// minimemcached.Run creates a new go routine to listen for new connections.
// In certain cases the new go routine may be created after/simultaneous with this cleanup resulting in a data race / nil pointer dereference.
// Mostly happens on CI during really short tests.
m.Close()
})
return m
Expand Down
Loading