update registrationParam to pex mapping #3624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslakhorst
requested review from
reinkrul,
gerardsn and
stevenvegt
as code owners
gerardsn
approved these changes
Dec 18, 2024
reinkrul
reviewed
Dec 18, 2024
| @@ -60,7 +60,8 @@ Optionally, a POST body can be provided with registration parameters, e.g.: | |||
|
|
|||
| This can be used to provide additional information. All registration parameters are returned by the search API. | |||
| The ``authServerURL`` is added automatically by the Nuts node. It's constructed as ``https://<config.url>/oauth2/<subject_id>``. | |||
| Registration parameters can only be used if the specific parameters and/or ``DiscoveryRegistrationCredential`` are required by the Presentation Definition. | |||
| Registration parameters can only be used if a specific parameters and/or ``DiscoveryRegistrationCredential`` are required by the Presentation Definition. | |||
| The key provided in the POST call can be matched by the path of a field in the Presentation Definition. So ``endpoint`` in the example above can be matched by the path ``$.credentialSubject.endpoint``. | |||
There was a problem hiding this comment.
I find the first sentence hard to read.
Suggested change
| The key provided in the POST call can be matched by the path of a field in the Presentation Definition. So ``endpoint`` in the example above can be matched by the path ``$.credentialSubject.endpoint``. | |
| The registration parameters should match the ``credentialSubject`` definition for the ``DiscoveryRegistrationCredential`` in the Presentation Definition. So ``endpoint`` in the example above can be matched by the path ``$.credentialSubject.endpoint``. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was unclear how a registration param matches a PEX constraint.