Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did:x509: x5c claim is DER base64, not PEM #3603

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Dec 10, 2024

Fixes #3596

Also deduplicates test code

@reinkrul reinkrul marked this pull request as ready for review December 11, 2024 06:18
certPEM = pem.EncodeToMemory(&b)
return cert, certPEM, err
}

func TestFindOtherNameValue(t *testing.T) {
t.Parallel()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from you, but this is not needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it

@reinkrul reinkrul merged commit df4ef2d into master Dec 11, 2024
9 checks passed
@reinkrul reinkrul deleted the iss3596-didx509-x5c-der branch December 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

did:x509 JWT x5c field processing incorrectly assumes PEM, should be base64 DER instead
2 participants