Rename pki.Validate to pki.CheckCRL for clarity on its purpose

[gerardsn]

No description provided.

[reinkrul]

Go style would be CheckCrl

[gerardsn]

https://go.dev/wiki/CodeReviewComments disagrees

Words in names that are initialisms or acronyms (e.g. “URL” or “NATO”) have a consistent case. For example, “URL” should appear as “URL” or “url” (as in “urlPony”, or “URLPony”), never as “Url”. As an example: ServeHTTP not ServeHttp. For identifiers with multiple initialized “words”, use for example “xmlHTTPRequest” or “XMLHTTPRequest”.

This rule also applies to “ID” when it is short for “identifier” (which is pretty much all cases when it’s not the “id” as in “ego”, “superego”), so write “appID” instead of “appId”.

Code generated by the protocol buffer compiler is exempt from this rule. Human-written code is held to a higher standard than machine-written code.

the linter doesn't know it's an acronym though

[tomelfring]

Just curious as I digged through this method to debug #3583, is CheckCRL really the only intended feature of this method? It does also check if the certificate is on a denylist (arguably some kind of CRL):

nuts-node/pki/validator.go

Line 176 in 51cb949

if v.denylist != nil {

And if the certificate is known in the truststore:

nuts-node/pki/validator.go

Line 191 in 51cb949

issuer, ok = v.getCert(cert.Issuer.String())

To me it looks like it does more than just a certificate revocation check.

[reinkrul]

https://go.dev/wiki/CodeReviewComments disagrees

Words in names that are initialisms or acronyms (e.g. “URL” or “NATO”) have a consistent case. For example, “URL” should appear as “URL” or “url” (as in “urlPony”, or “URLPony”), never as “Url”. As an example: ServeHTTP not ServeHttp. For identifiers with multiple initialized “words”, use for example “xmlHTTPRequest” or “XMLHTTPRequest”.
This rule also applies to “ID” when it is short for “identifier” (which is pretty much all cases when it’s not the “id” as in “ego”, “superego”), so write “appID” instead of “appId”.
Code generated by the protocol buffer compiler is exempt from this rule. Human-written code is held to a higher standard than machine-written code.

the linter doesn't know it's an acronym though

Oh... I'm almost sure someone pointed that out to me, but I can't remember now 🤦

[gerardsn]

@tomelfring

Just curious as I digged through this method to debug #3583, is CheckCRL really the only intended feature of this method? It does also check if the certificate is on a denylist (arguably some kind of CRL):

The denylist is a CRL under control of the user instead of the issuer. It should not be used but exists in case we need it in the future.

And if the certificate is known in the truststore:

We need this certificate to validate the signature on the CRL. So it is more a lookup of a trusted key than confirming the issuer is in the truststore. The trustchain is verified outside of this module and that is one of the reasons I wanted to change the name.