Refactor and merge Callbacks #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslakhorst
requested changes
May 31, 2024
auth/api/iam/api.go
Outdated
Comment on lines
218
to
220
| if request.Params.State == nil || *request.Params.State == "" { | ||
| return nil, oauthError(oauth.InvalidRequest, "missing state parameter") | ||
| } |
There was a problem hiding this comment.
If the Callback has an error but is missing the client state, the actual error will not be shown
There was a problem hiding this comment.
RFC6749 4.1.2.1. Error Response
state
REQUIRED if a "state" parameter was present in the client
authorization request. The exact value received from the
client.
I wasn't sure what to do with this, but I will wrap the error if there is one
| @@ -472,64 +472,6 @@ paths: | |||
| "$ref": "#/components/schemas/VerifiableCredential" | |||
| default: | |||
| $ref: '../common/error_response.yaml' | |||
| /iam/oid4vci/callback: | |||
There was a problem hiding this comment.
also add to calback API description that it's used for both calls.
woutslakhorst
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup and merge callbacks. This contains some fixes listed in #3152, but the majority is left for when we have access to a compliant issuer so we can do an end to end test of the flow.