split signature verification from verifier #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardsn
commented
Dec 13, 2023
gerardsn
commented
Dec 13, 2023
|
Is it only a refactor, no functional changes? |
reinkrul
requested changes
Dec 14, 2023
vcr/verifier/signature_verifier.go
Outdated
| } | ||
|
|
||
| // verifyVPSignature implements the Proof Verification Algorithm: https://w3c-ccg.github.io/data-integrity-spec/#proof-verification-algorithm | ||
| func (sv *signatureVerifier) verifyVPSignature(presentation vc.VerifiablePresentation, validateAt *time.Time) error { |
There was a problem hiding this comment.
that this one unexported, and the VerifySignature exported is weird
There was a problem hiding this comment.
exported; the signatureVerifier should probably get its own interface, but out of scope for now
| _, err := crypto.ParseJWT(jwtDocumentToVerify, func(kid string) (crypt.PublicKey, error) { | ||
| keyID = kid | ||
| return sv.resolveSigningKey(kid, issuer, at) | ||
| }, jwt.WithClock(jwt.ClockFunc(func() time.Time { |
There was a problem hiding this comment.
I realized clock skew is missing here..
reinkrul
approved these changes
Dec 14, 2023
rolandgroen
added a commit
to Headease/nuts-node
that referenced
this pull request
Dec 18, 2023
* master: complete s2s e2e test (nuts-foundation#2677) Cleanup unused file (nuts-foundation#2692) Discovery: implement server API (nuts-foundation#2659) VCR: Use JWT/JSON-LD constants from go-did (nuts-foundation#2691) Bump github/codeql-action from 2 to 3 (nuts-foundation#2687) split signature verification from verifier (nuts-foundation#2683)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
Verifierinterface contains theVerify,Validate, andVerifyVPmethods. The naming of these methods is ambiguous and there seems to be no clear separation of responsibilities.I've split/renamed the methods to
Verify/VerifyVPmethods on theVerifierthat should check the full correctness of the VC/VPVerifySignature/verifyVPSignaturethat only check if the signature on a VC/VP was valid at the given time.where the later are now on their own struct. This should make it easier to reuse in other places